search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
182 stars 86 forks source link

xkey_test12 fails, branch 6.4 on 32 bit #157

Closed ingvarha closed 4 years ago

ingvarha commented 4 years ago

I started test building varnish-modules branch 6.4 on misc arches yesterday.

xkey_test12 fails on epel-6-i386. Log attached.

Ingvar

ingvarha commented 4 years ago

xkey_test12.log

ingvarha commented 4 years ago

Reproduced with same error on 32-bit ppc, both on Ubuntu Xenial and Gentoo latest rolling relase.

"Not true: XKEY.g_hashhead_bytes (68) == 104 (104)"

ingvarha commented 4 years ago

For what it's worth, here's a variant of xkey/test12.vtc with values that works on 32 bit. The numbers are often in the ballpark of half of their 64 bit sisters.

test12.vtc.txt

dridi commented 4 years ago

Slap a feature 64bit statement at the beginning of the test and it will be skipped on 32bit arches.

benzvan commented 4 years ago

This makes sense. The bytes used by the hashhead struct will change with architecture due to the size of the pointers it contains.

benzvan commented 4 years ago

We're going to add this into our PR for #159