search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
185 stars 86 forks source link

Fix underflowing xkey gauges #160

Closed xordspar0 closed 4 years ago

xordspar0 commented 4 years ago

Fixes #159 Fixes #157

xordspar0 commented 4 years ago

Our test looks good!

image

gquintard commented 4 years ago

ok for me. Can we get some simpler tests and a squash before this goes in?

xordspar0 commented 4 years ago

All review comments are addressed and the branch is squashed. Let us know if we need to make any more changes.

gquintard commented 4 years ago

sorry, could you add the vtc from https://github.com/varnish/varnish-modules/issues/157#issuecomment-600605683 to the test suite? maybe with a _32bits suffix?

Once done, all good to go

xordspar0 commented 4 years ago

Is there a way to make a test only run on 32-bit hosts? I saw that there was a feature 64bit flag, but I didn't find a 32-bit equivalent. Also, just to clarify, test12 is 64-bit specific, but test13 is not architecture-specific.

dridi commented 4 years ago

I wouldn't bother with a 32bit version of the test, skipping on non-essential arches is fine.

gquintard commented 4 years ago

@xordspar0 , you heard the man, all good on our side then. Ready on yours?

xordspar0 commented 4 years ago

Yup, we're ready. 👍

gquintard commented 4 years ago

merged ,thanks a lot!