Closed sumit-kushwah closed 1 year ago
Ok, @gquintard Thanks for reviewing, I will make the changes as you suggested and write test cases.
Hi, @gquintard I have made the changes you recommended and wrote test cases for the new remove_bucket
function. Please let me know if there are any remaining issues that need to be addressed, or if there are any other areas of concern.
great, looks good on my side, I'll pull in the others to see what they have to say.
hl @nigoroll, @hermunn, @Dridi
I'm good with this. @sumit-kushwah could you rebase and squash everything into a single commit?
@daghf, Done.
Thanks a lot for the contribution, @sumit-kushwah
@gquintard, @daghf Thank you for taking the time to review and merge my pull request. I really appreciate it!
VOID remove_bucket(STRING key, INT limit, DURATION period, DURATION block)
Arguments:
Description
Remove the token bucket identified by the four parameters, if it exists.
Example:
it fixes the issue #204