gquintard
commented
1 year ago Hi,
That looks reasonable, can we get some testing around it please?
On Thu, Jul 20, 2023, 04:06 delthas @.***> wrote:
In a way, this reverts 1 https://github.com/varnish/libvmod-saintmode/commit/d8658c9331c17f4d2979f5b69c94d05866727a5a .
Previously, we would prevent users from blacklisting a backend from vcl_backend_error. But this is actually useful to users: when a backend fails to respond (and is considered healthy due to e.g. a varnishadm call), we may want to blacklist it for a short while, in order to return (retry) and be sure that we do not use this backend for our second try.
This changes the behavior to checking if there is an available backend, e.g. if we are in vcl_backend_response or vcl_backend_error.
You can view, comment on, or merge this pull request online at:
https://github.com/varnish/varnish-modules/pull/216 Commit Summary
- ca99b67 https://github.com/varnish/varnish-modules/pull/216/commits/ca99b678507f08618c6db0e0574214ef33ef4d45 vmod-saintmode: Allow using blacklist in vcl_backend_error
File Changes
(2 files https://github.com/varnish/varnish-modules/pull/216/files)
- M src/vmod_saintmode.c https://github.com/varnish/varnish-modules/pull/216/files#diff-fc2f58f9a03642817745d4ae6050eeda27dee8092f2da624ad27092130c1472a (4)
- M src/vmod_saintmode.vcc https://github.com/varnish/varnish-modules/pull/216/files#diff-a02dc29fe58c430ce1aa6935fb91a7ea32c5470c2ea9386abf13f96c8628c2c5 (5)
Patch Links:
- https://github.com/varnish/varnish-modules/pull/216.patch
- https://github.com/varnish/varnish-modules/pull/216.diff
— Reply to this email directly, view it on GitHub https://github.com/varnish/varnish-modules/pull/216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA42AKJDWFV3OAP773XNJJ3XREGMRANCNFSM6AAAAAA2RIBAAM . You are receiving this because you are subscribed to this thread.Message ID: @.***>
delthas
In a way, this reverts 1.
Previously, we would prevent users from blacklisting a backend from vcl_backend_error. But this is actually useful to users: when a backend fails to respond (and is considered healthy due to e.g. a varnishadm call), we may want to blacklist it for a short while, in order to
return (retry)and be sure that we do not use this backend for our second try.This changes the behavior to checking if there is an available backend, e.g. if we are in vcl_backend_response or vcl_backend_error.