search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
182 stars 86 forks source link

0.9.1 tests/cookie/08-overflow.vtc fails on 32bit #35

Closed ingvarha closed 8 years ago

ingvarha commented 8 years ago

tests/cookie/08-overflow.vtc fails on 32bit

Environment: varnish-modules-0.9.1 with varnish-4.1.3 on fedora rawhide/armhfp Example build logs: https://kojipkgs.fedoraproject.org//work/tasks/5551/15185551/build.log https://kojipkgs.fedoraproject.org//work/tasks/5780/15185780/build.log https://kojipkgs.fedoraproject.org//work/tasks/5901/15185901/build.log

ingvarha commented 8 years ago

Might even be a general 32bit problem. make check on i686 also fails: https://kojipkgs.fedoraproject.org//work/tasks/6178/15186178/build.log

ingvarha commented 8 years ago

For what it's worth: The culprit is the "Insane 6KB cookie value". A cookie of 5982 bytes works fine, while a 5983 long one fails. Reproduced on i686 and amv7l.

ingvarha commented 8 years ago

duh

1003 Error c workspace_client overflow

That's quite a good hint

So after reading the varnishd manual, and upping workspace_client to 32k (defaults to 16k on 32bit, 64k on 64bit) I solved the problem, something by something like this:

varnish v1 -cliok "param.set workspace_client 32k"

fgsch commented 8 years ago

So with this change is passing in both 32 and 64 bits?

ingvarha commented 8 years ago

It does. I actually used 64k for my fedora builds, for the change to have no impact on the 64bit builds.

This is only for make check, and the 32bit build systems I use for fedora/epel have enough memory. If this change trigs a problem, the user is probably running make check on a 32bit small memory arm system, and then he is kind-of on his own, I guess :-)