search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
185 stars 86 forks source link

Fix libtoolize not installing ltmain.sh on RHEL =< 6 #40

Closed gboddin closed 8 years ago

gboddin commented 8 years ago

Hello !

Here's a fix to be able to compile varnish-modules under RHEL 6 ( at least ).

Build output can be found here : https://travis-ci.org/gboddin/edge-repo/builds/155194300

Also, just in case, both varnish and varnish-modules are packaged there : http://repo.siwhine.net

Discussion about ltmain.sh missing on libtoolize : https://github.com/akheron/jansson/issues/182

dridi commented 8 years ago

I'd rather go for the usual build-aux directory, because then other files would be created there. One more directory, but eight less files in the root directory.

Can you please check whether it would work on RHEL 6 too?

If so, we also need to put build-aux in .gitignore.

lkarsten commented 8 years ago

Thanks for bringing this up.

Is this a Centos6 vs RHEL6 issue somehow? I don't see this issue building from a clean tree on my centos6 vm.

I've commited Dridi's suggestion, please let me know if you still run into problems.

I'm also slightly confused by your original patch, as the AC_CONFIG_AUX_DIR default includes "." already? (according to https://www.gnu.org/software/automake/manual/html_node/Optional.html )

gboddin commented 8 years ago

@lkarsten I'm not really good at all the autogen/libtoolize stuff, I managed to get this working in centos6 by applying the patch I gave. ( So I assume AC_CONFIG_AUX_DIR is not always containing . on all environment ).

I'm lauching a test with you last changes ! thanks.

gboddin commented 8 years ago

Ok so : https://travis-ci.org/gboddin/edge-repo/builds/155311734 works like a charm, thanks ! :)

And fyi this how it was failing before : https://travis-ci.org/gboddin/edge-repo/builds/155312461