search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
182 stars 86 forks source link

fix build on centos6 #58

Closed jlaceda closed 7 years ago

jlaceda commented 7 years ago

build on centos6 requires autoconf-2.65, automake-1.13, and this change in configure.ac

dridi commented 7 years ago

I will review this one.

dridi commented 7 years ago

Looks simple enough on a phone, I need to browse the autoconf docs on a usable screen first.

jlaceda commented 7 years ago

(doing some digging which i should have done before submitting this) Looks like AH_HEADER is a macro used to reference if theres already a header defined. AC_CONFIG_HEADERS is used to instantiate the config headers which is the purpose of that line.

source: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.65/html_node/Configuration-Headers.html

dridi commented 7 years ago

LGTM, this conflict is actually documented in automake, not autoconf:

https://www.gnu.org/software/automake/manual/automake.html#index-AC_005fCONFIG_005fHEADERS