Broken Makefile?

[stateisbad]

The sudo make install step seems to fail due to files not existing.

$ sudo make install
Making install in src
make[1]: Entering directory `/home/ubuntu/varnish-modules-0.12.0/src'
: vmod_bodyaccess.man.rst vmod_bodyaccess.3
: vmod_cookie.man.rst vmod_cookie.3
: vmod_header.man.rst vmod_header.3
: vmod_saintmode.man.rst vmod_saintmode.3
: vmod_softpurge.man.rst vmod_softpurge.3
: vmod_tcp.man.rst vmod_tcp.3
: vmod_var.man.rst vmod_var.3
: vmod_vsthrottle.man.rst vmod_vsthrottle.3
: vmod_xkey.man.rst vmod_xkey.3
make[2]: Entering directory `/home/ubuntu/varnish-modules-0.12.0/src'
make[2]: Nothing to be done for `install-exec-am'.
: vmod_bodyaccess.man.rst vmod_bodyaccess.3
: vmod_cookie.man.rst vmod_cookie.3
: vmod_header.man.rst vmod_header.3
: vmod_saintmode.man.rst vmod_saintmode.3
: vmod_softpurge.man.rst vmod_softpurge.3
: vmod_tcp.man.rst vmod_tcp.3
: vmod_var.man.rst vmod_var.3
: vmod_vsthrottle.man.rst vmod_vsthrottle.3
: vmod_xkey.man.rst vmod_xkey.3
 /bin/mkdir -p '/usr/share/man/man3'
 /usr/bin/install -c -m 644 ./vmod_bodyaccess.3 ./vmod_cookie.3 ./vmod_header.3 ./vmod_saintmode.3 ./vmod_softpurge.3 ./vmod_tcp.3 ./vmod_var.3 ./vmod_vsthrottle.3 ./vmod_xkey.3 '/usr/share/man/man3'
/usr/bin/install: cannot stat ‘./vmod_bodyaccess.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_cookie.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_header.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_saintmode.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_softpurge.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_tcp.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_var.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_vsthrottle.3’: No such file or directory
/usr/bin/install: cannot stat ‘./vmod_xkey.3’: No such file or directory
make[2]: *** [install-man3] Error 1
make[2]: Leaving directory `/home/ubuntu/varnish-modules-0.12.0/src'
make[1]: *** [install-am] Error 2
make[1]: Leaving directory `/home/ubuntu/varnish-modules-0.12.0/src'
make: *** [install-recursive] Error 1
$

The *.3 files don't exist. Something's amiss here. I should note I've tried this with 12.0, 12.1, as well as HEAD.

[stateisbad]

EDIT: Looks like rst2man is required, as that resolves the issue. Maybe it'd be worth it to make configure exit if it's not found, since it seems to keep the install from working?

[jstangroome]

Given the option, I'd prefer to see make install skip installing man pages if rst2man is unavailable.

[stateisbad]

Yeah, that would be fine, too. Whatever makes the most sense, as long as it doesn't cause the make install to bail.