varnishcache-friends / libvmod-geoip2

Varnish VMOD to query MaxMind GeoIP2 DB files
BSD 2-Clause "Simplified" License
39 stars 17 forks source link

Update README.md #31

Closed dvershinin closed 5 years ago

dvershinin commented 5 years ago

Packaged the VMOD for Varnish 4.1 and 6.0 LTS. The Readme update is for install instructions from RPM repository. More in blog post: https://www.getpagespeed.com/server-setup/varnish-geoip

codecov[bot] commented 5 years ago

Codecov Report

Merging #31 into devel will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel      #31   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files           1        1           
  Lines          96       96           
=======================================
  Hits           91       91           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 114125f...434c513. Read the comment docs.

fgsch commented 5 years ago

First, thanks for the PR! I've added the installation instructions to the wiki instead, hope you don't mind. I will add a link to that entry from the README shortly.

fgsch commented 5 years ago

@dvershinin isn't yum-config-manager --enable getpagespeed-extras-varnishXX needed for 4.0?

dvershinin commented 5 years ago

@fgsch not needed for 4.x. The default repository (one that you have enabled after yum install https://extras.getpagespeed.com/release-el7-latest.rpm has Varnish 4.1.x and its VMODs available for install right away.

Example:

screenshot 2019-01-14 18 50 13

The yum-config-manager --enable getpagespeed-extras-varnishXX is only needed for Varnish 6.0.

In fact, if someone were on Varnish 4.1 first and then want to upgrade to 6.0, then can just do the yum-config-manager --enable getpagespeed-extras-varnish60 and yum update varnish and that would allow for easy upgrade to corresponding VMODs:

screenshot 2019-01-14 18 57 48