search

varnishcache-friends / libvmod-geoip2

Varnish VMOD to query MaxMind GeoIP2 DB files
BSD 2-Clause "Simplified" License
39 stars 17 forks source link

remove the null db obj test case #32

Closed nigoroll closed 5 years ago

nigoroll commented 5 years ago

This is now handled in varnish-cache, see

https://github.com/varnishcache/varnish-cache/commit/9ceeed8aa880bdb3eb0378aee1ace3d2dc6fca0f

codecov[bot] commented 5 years ago

Codecov Report

Merging #32 into devel will decrease coverage by 5.2%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #32      +/-   ##
==========================================
- Coverage   94.79%   89.58%   -5.21%     
==========================================
  Files           1        1              
  Lines          96       96              
==========================================
- Hits           91       86       -5     
- Misses          5       10       +5
Impacted Files Coverage Δ
src/vmod_geoip2.c 89.58% <0%> (-5.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 385fd4f...653f2e9. Read the comment docs.

fgsch commented 5 years ago

Thanks for the PR. I've just committed a fix for the tests and some changes to the code to address it.