varnishcache-friends / libvmod-geoip2

Varnish VMOD to query MaxMind GeoIP2 DB files

BSD 2-Clause "Simplified" License

39 stars 17 forks source link

Increased the Varnish test timeout. #46

Closed GeertHauwaerts closed 1 year ago

GeertHauwaerts commented 2 years ago

Test b00002 completes in 60.4s and is killed right before completion. I increased the varnishtest timeout to 120s (default is 60s)

fgsch commented 2 years ago

Hi. I cannot reproduce this. What varnish and maxminddb versions are you using? Can you attach the various logs?

GeertHauwaerts commented 2 years ago

Logs:

Packages:

libmaxminddb0 1.6.0-0+maxmind1~bionic
libmaxminddb-dev 1.6.0-0+maxmind1~bionic

OS:

Ubuntu 18.04.6 LTS (bionic)

Varnish:

Version: 6.0.10 revision 9a7da4ff4c0c824af33e230740a11e99fdca23d9
Origin: deb https://packagecloud.io/varnishcache/varnish60lts/ubuntu bionic main

codecov[bot] commented 2 years ago

Codecov Report

Merging #46 (778935d) into devel (7e9e56d) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 778935d differs from pull request most recent head 263e3ca. Consider uploading reports for the commit 263e3ca to get more accurate results

@@           Coverage Diff           @@
##            devel      #46   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           1        1           
  Lines         107      107           
=======================================
  Hits          102      102           
  Misses          5        5

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

fgsch commented 1 year ago

I haven't been able to reproduce this and I don't believe it should be needed under normal circumstances. I think something else is going on here, and I'd be happy to help you debug it but for now, I'm going to close this PR.