search

varnishcache / libvmod-example

Starting point for vmod development for Varnish Cache
The Unlicense
13 stars 12 forks source link

cci integration, and make it pass #8

Closed gquintard closed 3 years ago

gquintard commented 3 years ago

it would be nice for people forking this repository (even though vcdk exists) had a template for ci. The first commit add commit-triggered and weekly commits. And the second updates the code to make said tests pass.

gquintard commented 3 years ago

@Dridi , just checked: no need to change the yaml file when you rename the vmod

dridi commented 3 years ago

cough README cough

gquintard commented 3 years ago

already works as-is :-)

dridi commented 3 years ago

Nope, I followed the instructions and my README contains this:

$ ./rename-vmod-script foo
rm 'rename-vmod-script'
All done.

For your cut&paste needs:
git commit -a -m "Automatic rename of libvmod-example to libvmod-foo."
$ git commit -a -m "Automatic rename of libvmod-example to libvmod-foo."
[...git output...]
$ git grep CircleCI -- README.rst
README.rst:[![CircleCI](https://circleci.com/gh/varnishcache/libvmod-foo/tree/master.svg?style=svg)](https://app.circleci.com/pipelines/github/varnishcache/libvmod-foo?branch=master)

Make the rename script remove the line containing CircleCI from the README?

gquintard commented 3 years ago

oh, absolutely correct, the renaming is done, but make no sense since it's a URL. i added a commit to nuke the line

gquintard commented 3 years ago

rebased and pushed