varnishcache / pkg-varnish-cache

Package building scripts for official Debian and Redhat packages of Varnish Cache.
21 stars 30 forks source link

Add support for Ubuntu 20.04 'Focal Fossa' #139

Closed geerlingguy closed 4 years ago

geerlingguy commented 4 years ago

It seems that Ubuntu 20.04's default apt repo includes a varnish package at 6.2.x, but the current version of Varnish is 6.4.x.

Packagecloud currently has packages for bionic and xenial, but not focal, so installation fails if you try using the PPA on Ubuntu: https://packagecloud.io/varnishcache/varnish64

Could we get support added for Ubuntu 20.04 Focal?

(Related: https://github.com/geerlingguy/ansible-role-varnish/issues/95).

martin-g commented 4 years ago

Hi,

There is an open PR at https://github.com/varnishcache/varnish-cache/pull/3263 that makes it very easy to add Ubuntu 20.04 to the list of OSes for which a package will be built!

I think it would be a good idea to replace Debian Bullseye with Ubuntu 20.04, because Bullseye is the new Debian testing. @Dridi @gquintard Do you agree ?

gquintard commented 4 years ago

I don't see a reason to remove bullseye, quite the opposite actually, it will serve a "peek-into-the-future" platform and help us catch problems with newer libs/compilers.

It will be easy to add focal to the list and build packages from now on, but the current stance is to freeze the supported distribution on the release date. So adding focal support means packages for weeklies and the next release in September but not 6.4

wkhayrattee commented 4 years ago

Hey @martin-g the PR for #https://github.com/varnishcache/varnish-cache/pull/3263 and #https://github.com/varnishcache/varnish-cache/pull/3313 have been closed.

If there any chance we see v6.4 for focal in the next few days? Or is it a dead-end till the next release as pointed out by @gquintard ?

martin-g commented 4 years ago

I'll let the Varnish team decide that! I can send a new PR adding Focal as soon as the team approves it!

If approved the the .deb package will be a nightly build until the next official release is made!

wkhayrattee commented 4 years ago

I can send a new PR adding Focal as soon as the team approves it!

If approved the the .deb package will be a nightly build until the next official release is made!

Oh yes please if you can thank you.

martin-g commented 4 years ago

https://github.com/varnishcache/varnish-cache/pull/3317

Varnish team will decide when/whether to merge it!

gquintard commented 4 years ago

merged

geerlingguy commented 3 years ago

@gquintard - It looks like the focal build is available under weeklies, but not under the 6.4 releases: https://packagecloud.io/varnishcache/varnish64. Is there any timeline for getting a stable release for 20.04?

gquintard commented 3 years ago

Hi,

No timeline, but we'll gladly review PRs for extra distribution support.

Note that we generally only consider new dist support only for weeklies and LTS version, so 6.4 is not likely to support fossa.

-- Guillaume Quintard

On Mon, Jul 6, 2020 at 12:00 PM Jeff Geerling notifications@github.com wrote:

@gquintard https://github.com/gquintard - It looks like the focal build is available under weeklies https://packagecloud.io/varnishcache/varnish-weekly, but not under the 6.4 releases: https://packagecloud.io/varnishcache/varnish64. Is there any timeline for getting a stable release for 20.04?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/varnishcache/pkg-varnish-cache/issues/139#issuecomment-654410820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA42AKOTXHEAZFWDLDZA4W3R2INLHANCNFSM4M6APYEA .

nicovs commented 3 years ago

@gquintard you mean Focal is not LTS? https://releases.ubuntu.com/20.04/ Or am i missing something? :)

gquintard commented 3 years ago

@nicovs , I mean that 6.4 isn't an LTS, so it's not likely to see support for a new distribution (focal in this case)