varnishcache / pkg-varnish-cache

Package building scripts for official Debian and Redhat packages of Varnish Cache.
21 stars 30 forks source link

removing systemd_requires #153

Closed gquintard closed 2 years ago

gquintard commented 2 years ago

the systemd_requires macro doesn't seem to work anymore on the latest stable fedora (it triggers an unknown tag error), so I copied what I saw in the official fedora package.

for context: I'm preparing a PR on the varnish-cache repository getting rid of centos:8 and adding fedora:latest and fedora:rawhide, that's how I hit that error.

tagging @Dridi and @ingvarha because they know this part of the woods

dridi commented 2 years ago

It's still present:

$ mock --root fedora-rawhide-x86_64 install /usr/lib/rpm/macros.d/macros.systemd
[...]
$ mock --root fedora-rawhide-x86_64 --chroot rpm --eval %systemd_requires
[...]
Start: chroot ['rpm', '--eval', '%systemd_requires']

Requires(post): systemd 
Requires(preun): systemd 
Requires(postun): systemd 

Finish: chroot ['rpm', '--eval', '%systemd_requires']

What we might need instead is:

+BuildRequires systemd-rpm-macros
-%systemd_requires
+%{?systemd_requires}

Can you give it a try?

gquintard commented 2 years ago

that works, but we have to test for fedora as centos doesn't have systemd-rpm-macros

dridi commented 2 years ago

I pushed the change slightly differently, keeping the separation between BuildRequires and Requires entries, and more importantly leaving the centos-8 removal out of the fedora-rawhide enablement. They are really two different issues.