search

varnishcache / varnish-cache

Varnish Cache source code repository
https://www.varnish-cache.org
Other
3.56k stars 366 forks source link

Minor build fixes #4061

Closed stevendore closed 4 months ago

stevendore commented 4 months ago

The first commit I noticed there was a missing comma in wflags.py UNDESIRABLE_WFLAGS. The build system didn't seem to care either way but figured it was easy enough to update.

The second commit relates to the auto-generated BUILD_VMOD_$NAME helper generated by VARNISH_VMOD() in configure.ac. When a VMOD adds a CFLAG with libvmod_$1_la_CFLAGS the object name is no longer vmod_$name.lo but $library-vmod_name.lo this changes the build order such that the VCC autogenerated files would not be guaranteed to compile first causing compilation issues. Updating to the $libvmod_$1_la_OBJECTS fixes the build order by letting automake/tools figure out the right object name. It might add in more objects than really desired but it's probably better to have the VCC files always built first.

Issue found in the wild: https://github.com/varnish/libvmod-curl/issues/56

nigoroll commented 4 months ago

I cherry-picked the wflags fix, but would like to leave the rest with @Dridi .

nigoroll commented 4 months ago

Merging as per IRC