varnishcache / varnish-cache

Varnish Cache source code repository
https://www.varnish-cache.org
Other
3.56k stars 366 forks source link

Specify how to disable timeouts #4069

Closed dridi closed 4 months ago

dridi commented 4 months ago

Following consensus, this patch series formalizes several things:

I tried to be as thorough as possible, following the trail of relevant timeout parameters.

Fixes #3045

dridi commented 4 months ago

Of course I had to forget something, and it was Lck_CondWaitTimeout(), which I already added to the patch series. I decided to be prudent and keep support for zero meaning never timing out, but looking closely the only case where we use zero is actually in the Lck_CondWait() function, and Lck_CondWaitTimeout() when we forward a zero to Lck_CondWaitUntil().

So I think we could safely make zero no longer special, and in that case have a 1ms timed wait, or less.