varnishcache / varnish-cache

Varnish Cache source code repository
https://www.varnish-cache.org
Other
3.56k stars 366 forks source link

ESI with bad status code is not aborted for empty includes #4070

Closed nigoroll closed 4 months ago

nigoroll commented 4 months ago

if the esi_include_onerror feature is off, then the top-level response is aborted.

This is not what we currently do.

If the body is known empty (so not streaming), we do not abort.

Originally posted by @nigoroll in https://github.com/varnishcache/varnish-cache/issues/4065#issuecomment-1971276803