varnishcache / varnish-cache

Varnish Cache source code repository
https://www.varnish-cache.org
Other
3.56k stars 365 forks source link

mgt: Always recreate secret file on startup #4092

Closed scance closed 2 months ago

scance commented 3 months ago

Failures seem to be caused by an ongoing github incident (https://www.githubstatus.com/) AFAICT.

walid-git commented 3 months ago

I think you also have a failing test:

**   top   === shell -err -expect {Cannot create secret-file in} {
**** top   shell_cmd|exec 2>&1 ; 
**** top   shell_cmd|\tmkdir /tmp/vtc.97918.6a48ac11/is_a_dir /tmp/vtc.97918.6a48ac11/is_a_dir/_.secret
**** top   shell_cmd|\tvarnishd -n /tmp/vtc.97918.6a48ac11/is_a_dir -d -a :0
**** dT    1.014
**** top   shell_out|Error: Cannot remove pre-existing secret-file in /tmp/vtc.97918.6a48ac11/is_a_dir (Is a directory)
**** top   shell_out|(-? gives usage)
**** top   shell_status = 0x0002
---- top   shell_expect not found: ("Cannot create secret-file in")
*    top   RESETTING after ../../../../bin/varnishtest/tests/u00000.vtc
*    top   TEST ../../../../bin/varnishtest/tests/u00000.vtc FAILED
#    top  TEST ../../../../bin/varnishtest/tests/u00000.vtc FAILED (1.014) exit=2
FAIL tests/u00000.vtc (exit status: 2)
scance commented 3 months ago

Indeed I do... Will need to think of the relevance of that existing test.

dridi commented 2 months ago

bugwash: ok