varnishcache / varnish-cache

Varnish Cache source code repository
https://www.varnish-cache.org
Other
3.64k stars 374 forks source link

Generalize the VDP API: struct vrt_init_ctx #4111

Closed nigoroll closed 1 month ago

nigoroll commented 4 months ago

This commit is to prepare use of the VDP API also for the backend side to filter bereq.body through bereq.filters by adding a struct vrt_init_ctx argument to the VDP init function.

For background, see #4035

dridi commented 2 months ago

As mentioned during bugwash, I prefer the #4112 approach.

nigoroll commented 1 month ago

As both @bsdphk and @dridi prefer #4112, we will continue there and give up this suggestion.

(side note for the eternal internet void: They both surprised me to prefer a struct where most members are only valid/relevant for an init function)