search

varnishcache / varnish-cache

Varnish Cache source code repository
https://www.varnish-cache.org
Other
3.56k stars 365 forks source link

vbt: Move backtrace code to libvarnish #4114

Closed dridi closed 1 month ago

dridi commented 1 month ago

This is an old patch series from more than a year ago that I mentioned briefly to @bsdphk back then. The idea was to move the back-trace rendering code to libvarnish and make the panic code use it.

We needed to print back-traces outside of varnishd to track down an alleged unknown bug in our getaddrinfo() usage, that would only happen under an unknown set of circumstances, but it turned out to be a silly overflow not reported as such by glibc.

In other words, it took us a back-trace to realize we were facing another incarnation of #3765 because 247eb50f47d4dae5eeacc54375eb3f2adde086a1 had not been back-ported to the 6.0 branch. Once the problem was solved the VBT code was forgotten until last Friday.

Apologies for the delay.

bsdphk commented 1 month ago

OK with me.

dridi commented 1 month ago

I forgot to link the following commits to this ticket: https://github.com/varnishcache/varnish-cache/compare/9d40af77fb153489e0f8c95b61de08a0daf15fb7...41a1a42dd9e4390d400fcc205bf1d3eac7970191