search

varnishcache / varnish-cache

Varnish Cache source code repository
https://www.varnish-cache.org
Other
3.59k stars 367 forks source link

Add a parameter for the panic buffer size #4132

Closed nigoroll closed 2 weeks ago

nigoroll commented 2 weeks ago

64k ought to be enough for everyone. /s

nigoroll commented 2 weeks ago

@dridi

I would change the maximum from 1GB to 1MB, because 1GB seems excessive.

You mean, 1MB ought to be enough for everyone?

I would prefer a limit which is waaaay out. At first I thought it could be 1TB, but we really should have a lot of headroom.

@asadsa92 thank you for your suggestions, do you see them reflected in the SQUASHME commit?

bsdphk commented 2 weeks ago

Ok with me.

dridi commented 2 weeks ago

You mean, 1MB ought to be enough for everyone?

YES!

I could be convinced to go one order of magnitude higher, but 10MB sure ought to really be enough for everyone. You can fit a couple holy books in 10MB, and I don't expect anyone to read through a book-worth of panic output.