varnishcache / varnish-devicedetect

VCL based device detection for Varnish Cache.
Other
299 stars 88 forks source link

Why 'pc' type instead of the usual 'desktop' one? #6

Closed guiohm closed 11 years ago

guiohm commented 11 years ago

Well, it's obviously not an issue but I'm curious about this choice. Any particular reason?

lkarsten commented 11 years ago

The initial base ruleset came from merging the VCL files of some big Norwegian newspapers. There is no known reason for the "pc" usage, just historical cruft.

lkarsten commented 11 years ago

If the question was "shouldn't it be changed to desktop?", then I think the answer is "yes I think that would be good, but no we shouldn't do that".

I don't want to break upgrades for people using it.

If you feel this is important to fix, reopen the ticket and we'll see if anyone else chimes in.