Consider supporting PHP 7.0

varspool / Wrench

A simple PHP WebSocket implementation for PHP 7.1

Do What The F*ck You Want To Public License

596 stars 210 forks source link

Consider supporting PHP 7.0 #102

Closed mcordingley closed 7 years ago

mcordingley commented 7 years ago

From skimming the code, I don't see anything implemented that actually requires features available only in 7.1 or higher. Neither does PHPStorm detect anything that would break on 7.0. Meanwhile, Debian 9.0 is releasing this summer with PHP 7.0. It won't be until Debian 10 (likely to release in 2019) that a large number of servers will be able to use PHP 7.1 code.

This is the first WebSocket client library I've found that's actually written well. Please don't shut me out of it.

mcordingley commented 7 years ago

Actually, scratch that. I see that you're committed to supporting the 2.x release and that the latest update to it is relatively recent. Carry on, good sirs.