search

varspool / Wrench

A simple PHP WebSocket implementation for PHP 7.1
Do What The F*ck You Want To Public License
596 stars 210 forks source link

Add access to headers and query params from the original web sockets http request #37

Closed Rupert-RR closed 11 years ago

Rupert-RR commented 11 years ago

This allows access to headers and query parameters included in the initial upgrade HTTP request. Useful for extracting language preferences, session ids etc. It works for me, and should not cause any backwards compatibility problems, but I will see if anyone has any comments before merging.

dominics commented 11 years ago

:+1: (You should have access to merge)

Could you please check that you haven't introduced those inconsistent line endings with these commits? (Fine if they were there already.) And/or fix before merging?

dominics commented 11 years ago

Ah, yes, these commits have Windows line endings and tabs. I've fixed that and opened #38

Rupert-RR commented 11 years ago

Yes, but I thought I would wait and see if anyone had any problems with it before merging.

I'm fixing the Scrutinizer comments (where useful). It is quite possible that I introduced inconsistent line-endings - what line-endings should we be using (I'm working on OSX)?

Rupert-RR commented 11 years ago

(Oops - meant to comment rather than close!)

Rupert-RR commented 11 years ago

And oops again - I hadn't seen that it was you who closed it! I'll close this. Do you know how I can retrieve your modified pull request to add in changes to get rid of some of the Scrutinizer warnings?

dominics commented 11 years ago

@Rupert-RR Sure. Something like:

git remote add upstream git://github.com/varspool/Wrench.git
git fetch upstream
git checkout feature-headers

In other words, add this repository as another remote, then pull or fetch and checkout the branch. In any case, I'll just merge it now, and you can rebase on top of master if you like.