search

varspool / sphpdox

PHPDoc to Sphinx/ReStructured Text API documentation tool
GNU General Public License v3.0
48 stars 16 forks source link

modernized dependencies #21

Closed philiplb closed 6 years ago

philiplb commented 6 years ago

So this works with symfony 4.

philiplb commented 6 years ago

@varspool any chance this could get merged?

DanielSiepmann commented 6 years ago

@philiplb I think this pull request has better chances if the build does not fail.

Currently the issue is that .travis.yml was not updated to run with corresponding PHP versions. Also the new dependencies raise the required PHP version up to 7.1 as a minimum. 5.6 is still supported on some operating systems. I'm not sure whether the author likes this breaking chance.

Did you try to only allow the installation of you versions in addition? composer will by itself require the newest possible version. If you add the required versions in addition and update the .travis.yml you might get what you want, without being breaking.

philiplb commented 6 years ago

Good point, will update to the needed version(s).

sabbelasichon commented 6 years ago

@philiplb I did a new pull request #22 with the same intention. If you like you can comment on it. Would like to merge the PR as soon as possible.