varun19299 / deep-atrous-guided-filter

Deep Atrous Guided Filter for Image Restoration in Under Display Cameras (UDC Challenge, ECCV 2020).
https://varun19299.github.io/deep-atrous-guided-filter/
36 stars 6 forks source link

Is there a typo in the loss.py #4

Closed qimiaohao closed 3 years ago

qimiaohao commented 3 years ago

Hi: Very impressive work. I want to run the training code in my dataset. Is there a typo for the line 58 in loss.py

self.total_loss += +self.image_loss + self.cobi_rgb_loss

what does it mean of “+=+”

is it: self.total_loss = +self.image_loss + self.cobi_rgb_loss

Thank you very much

varun19299 commented 3 years ago

self.total_loss += +self.image_loss + self.cobi_rgb_loss is syntactically correct, but should have been

self.total_loss += self.image_loss + self.cobi_rgb_loss (a typo).

Does this help?

qimiaohao commented 3 years ago

self.total_loss += +self.image_loss + self.cobi_rgb_loss is syntactically correct, but should have been

self.total_loss += self.image_loss + self.cobi_rgb_loss (a typo).

Does this help?

Sorry. So it is correct? The correct code is still self.total_loss += +self.image_loss + self.cobi_rgb_loss ? Thank you.

varun19299 commented 3 years ago

We'll update it as += self.image_loss..., but the existing version works too.

qimiaohao commented 3 years ago

Thank you very much