varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀
https://tomper-wear.netlify.app
MIT License
40 stars 49 forks source link

Search bar bug #16

Closed sagnik2001 closed 2 years ago

sagnik2001 commented 2 years ago

Issue reference:

Search Bug Filter issue resolved. #11

Proposed changes:

The Search Bar was previously working if you type all lower case which is not the expected behavior. I have fixed 2 issues:

Type of change:

Checklist:

Screenshot from 2022-03-03 10-14-00

Current working behavior.

netlify[bot] commented 2 years ago

🔮 Deploy Preview for tomper-wear canceled.

🔨 Explore the source changes: f8b96465c2ba79d8b356c462ff9f37918526f248

🔍 Inspect the deploy log: https://app.netlify.com/sites/tomper-wear/deploys/622052391198d300077b35dd

varunKT001 commented 2 years ago

Hey @sagnik2001 👋,

Why did you update the react-scripts dependencies 🤔 Is there any problem starting the dev-server?

I can see you added some new lines to the components and files. Now two things:

Now,

After doing so, fill the checklist 👍

sagnik2001 commented 2 years ago

Okay, I do the required changes I did update the react-scripts because in my local machine it was not working. Ok, I do as instructed.

varunKT001 commented 2 years ago

What was the issue?

sagnik2001 commented 2 years ago

The local server was failing to run.

varunKT001 commented 2 years ago

Wait then, let me check.

sagnik2001 commented 2 years ago

Should I make the changes that you asked for and again commit ??

varunKT001 commented 2 years ago

wait, for now, let me check the issue 👍

varunKT001 commented 2 years ago

Hmm, since react-scripts@5 is not causing any breaking change, we can have that, no need to change. Also, I have tested the PR, works fine 👍 Just make the other changes 👍

sagnik2001 commented 2 years ago

Okay

sagnik2001 commented 2 years ago

Hey, I have made the commits. Have a look and thanks for the opportunity

varunKT001 commented 2 years ago

@sagnik2001 comments bhi to hatana tha 🙂

sagnik2001 commented 2 years ago

Done, sorry missed out that previously thanks

varunKT001 commented 2 years ago

Great 🎉, Thanks for your contribution @sagnik2001 Stay tuned, more issues will be added. Also, if you find anything that could be improved, create an issue 👍 Also, the backend and the admin panel will soon be added, I'll be happy to see you contributing to them too 😅 You can join the discord channel also (finally we have it now 😅)

Happy contributing 🥳