Fixed-Phone-Number-Validation

[bhavya-parikh]

Issue reference: https://github.com/varunKT001/tomper-wear-ecommerce/issues/3 Form was taking any number of digits and was allowing digits even more than 10,

Proposed changes:

Added validation check for phone number

Type of change:

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

Checklist:

• [ ✔] My code follows the style guidelines of this project
• [ ✔] I have performed a self-review of my own code
• [✔ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation //No changes needed
• [✔ ] My changes generate no new warnings

Additional info (if any):

[netlify[bot]]

🔮 Deploy Preview for tomper-wear canceled.

🔨 Explore the source changes: 9e604bd91b722dc195b463f3934b5227a8d5bc6d

🔍 Inspect the deploy log: https://app.netlify.com/sites/tomper-wear/deploys/622072f85aa6c20007d44c66

[varunKT001]

Hey @Bhavya-Parikh 👋, First of all, to fill out the checklist, you have to do this:

Do this 
- [x]

Not this
- [✔]

Secondly, the way you have written the regex is not correct. It won't work. This is the correct way:

if (!phone_number || !/^\d{10}$/.test(phone_number) {
    ...
}

You have changed the error message to Enter valid phone number. It was not to be changed. Please don't make any changes to it.

Also, please write a good commit message like updated phone number validation.

Now since you have already committed your change, it would require a force push to the main branch to rename the message, which is not good actually. I can squash and merge to avoid this, but it's not a good practice. So go ahead, delete your fork, fork it again, make the changes again and make a new pull request with a good commit message this time.

I am closing this pull request as of now.