varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials πŸ˜€
https://tomper-wear.netlify.app
MIT License
38 stars 48 forks source link

Confirm Password field added in registration page #23

Closed Siddhesh777 closed 2 years ago

Siddhesh777 commented 2 years ago

Issue reference:

13

Proposed changes: I added a field for confirming password and if they both don't match it gives an error.

Type of change:

Checklist:

Additional info (if any):

issue solved

netlify[bot] commented 2 years ago

‼️ Deploy request for tomper-wear rejected. Learn more about Netlify's sensitive variable policy

πŸ”¨ Explore the source changes: 13a23e493136ddc3ee2a0f3a12d78362deb9ca21

varunKT001 commented 2 years ago

Hey @Siddhesh777 πŸ‘‹,

Some improvements needed:

After making the changes, fill the checklist in the pull request and tag me here πŸ‘

Siddhesh777 commented 2 years ago

Hey @varunKT001 πŸ‘‹ Done with the improvements mentioned. Kindly check and merge.

varunKT001 commented 2 years ago

@Siddhesh777 One small change though πŸ˜… Change the error message for non-matching passwords to: Passwords don't match Do this small change, and I'll merge πŸ‘

Also, please make a habit of writing good commit messages, it will help me/mentors to get a brief idea about what was changed without the need to go and check the differences.

Siddhesh777 commented 2 years ago

@varunKT001 Changed the error message. Yes, I am making a habit of writing good commit messagesπŸ˜… Thank You.

varunKT001 commented 2 years ago

Changed the error message.

Great work @Siddhesh777 πŸš€

Yes, I am making a habit of writing good commit messagesπŸ˜…

These small habits that you'll during these 3 months of GSSoC'22, will surely help you in the future πŸ˜„

Thanks for your contribution πŸŽ‰

Siddhesh777 commented 2 years ago

Thank you very much @varunKT001 πŸ˜„ I will try to find more bugs and enhance this projectπŸ˜„

varunKT001 commented 2 years ago

@Siddhesh777 Sure, if you ever need help, just ping me on the TomperWear discord channel, I'll be happy to help πŸ˜„