varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀
https://tomper-wear.netlify.app
MIT License
38 stars 48 forks source link

Feature Request: Adding hover effect on home page slides #24

Closed PM-00-STAR closed 2 years ago

PM-00-STAR commented 2 years ago

Is your feature request related to a problem? Please describe.

Hey, I am a GSSoC22 contributor, would be glad to contribute in your project It would look more dynamic if you allow me to add hover effect on these 3 slides

WhatsApp Image 2022-03-04 at 17 59 42

Describe the solution you'd like.

The solution would make them dynamic

Additional context (if any)

No response

github-actions[bot] commented 2 years ago

Hey @PM-00-STAR 👋, thank you for raising an issue. Please make sure that it is detailed, and also following the provided template.

varunKT001 commented 2 years ago

Hey @PM-00-STAR 👋, You can work upon it. But since I don't know what type of hover effect you have thought of implementing, I can't assure you that your change will get merged, since it would depend on my personal preference 😕

If I liked your implementation, I'll surely accept it, but I can't guarantee it 🙂

If you ask me, I would like to see something like I have implemented in my portfolio, ➡️ varuntiwari.xyz If you go to the Other Projects section, you can see some cards there. You can try to make it something like that, where you can keep the title and the logo showing, and keep the text hidden inside the card, which reveals on hover. You can also try to improve in that and make something unique. Its up to you 👍

But still, I won't guarantee acceptance, since, for that, it should look good on the TomperWear website.

So, tell me what you think, if you still wanna work on it, I'll assign it to you 👍 Otherwise, you can close the issue, no worries 😄

alceil commented 2 years ago

Can i work on this issue @varunKT001

PM-00-STAR commented 2 years ago

Can i work on this issue @varunKT001

i am working on this

varunKT001 commented 2 years ago

@PM-00-STAR You are not yet assigned 🙂 so why are you working on it 🙂

Also, there is a similar issue, on which someone is working on.

So, I have to close this issue.

Don't worry, I'll be making some new issues, you can work on that. Or, you can create some other issue of your own 👍

PM-00-STAR commented 2 years ago

Actually i am interested in frontend issues , if you find issue relevant to this project then please let me know i am willing to contribute in this project @varunKT001

varunKT001 commented 2 years ago

@PM-00-STAR Sure, whenever I make any frontend-related issue, you can comment on that issue that you're willing to work on it, I'll assign you that. But make sure you comment first because I'll assign on first come first serve basis.

Also if you find some point of improvements, you can create an issue 👍

PM-00-STAR commented 2 years ago

Ok

On Mon, Mar 7, 2022, 00:36 Varun Tiwari @.***> wrote:

@PM-00-STAR https://github.com/PM-00-STAR Sure, whenever I make any frontend-related issue, you can comment on that issue that you're willing to work on it, I'll assign you that. But make sure you comment first because I'll assign on first come first serve basis.

Also if you find some point of improvements, you can create an issue 👍

— Reply to this email directly, view it on GitHub https://github.com/varunKT001/tomper-wear-ecommerce/issues/24#issuecomment-1060020628, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATNFQBJUQ4LCAG6EGAL7X2TU6T64HANCNFSM5P5NP7MA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>