Closed Shubham29012001 closed 2 years ago
‼️ Deploy request for tomper-wear rejected. Learn more about Netlify's sensitive variable policy
🔨 Explore the source changes: 8c2993afa84c78d83f1bf6ad35a49f180ac4495c
I just removed some dependencies from package.json Update your fork using the fetch upstream option present and the merge conflicts will be removed 👍
Hey @varunKT001, when I am clicking on Fetch Upstream, it is prompting me to open a pull request in it. Can you assist me with it?
Okay, then you just download the new package.json
and package-lock.json
file and add them to your local clone 🙂
This may sound too naive, but believe me, you wouldn't want to go the git way 😅. But still, if you wanna try, you can perform a mixed reset. After that stage only the index.js
styles.js
and constant.js
. Make a commit and do a force push 🙂
I would recommend doing the copy-paste instead of going the git way 😆
Also, I didn't notice while writing the setup guide, that if we rename .env.sample
, it will delete it in the pr 🙁. Sorry for that, but please also add the .env.sample
back.
I'll edit the setup guide after your pr is merged 👍
Hey @varunKT001. It worked. Can you please checkout the footer section?
Some more changes:
styles.js
(since there is no background)constant.js
, so remove the width and height properties of SVG from styles.js
<hr>
, use a div with className of underline
.
.underline {
width: 95%;
height: 1px;
margin-bottom: 1rem;
background: var(--clr-grey-7);
}
<Link>
, use <a>
with href='mailto:tiwarivarun819.vt33.vt@gmail.com'
key={id}
you have written className={id}
🙂 fix thatconstant.js
, change the color of github icon to whiteDo the changes and then tag me here 👍
Hey @varunKT001, I have applied all the mentioned changes in the footer.
Nice work 👍 Thanks for your contribution @Shubham29012001 🚀
We also added the backend and the admin panel to the GSSoC22 project list, you can find links to them from the readme. I'll happy to see you working on those projects too 😄
Fix #8
Add Better Responsive Footer
UI/UX Change