varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀
https://tomper-wear.netlify.app
MIT License
38 stars 48 forks source link

Feature Request: Make the cards Responsive #35

Closed Kumar-laxmi closed 2 years ago

Kumar-laxmi commented 2 years ago

Is your feature request related to a problem? Please describe.

image

In above image we can make the cards named - Mission, Vision and History as responsive.

Describe the solution you'd like.

I will be installing vanilla-tilt.js file and also calling it which has many pre-defined js functions that have many interactive and stunning functions that can convert static card view to a much dynamic card view.

Additional context (if any)

Not any thing much for now!!!

github-actions[bot] commented 2 years ago

Hey @Kumar-laxmi 👋, thank you for raising an issue. Please make sure that it is detailed, and also following the provided template.

varunKT001 commented 2 years ago

Hey @Kumar-laxmi 👋

The cards are responsive for all screen sizes, you can test them using the dev tools.

Also, can you share some examples of what type of dynamic card view you are talking about?

Kumar-laxmi commented 2 years ago

https://micku7zu.github.io/vanilla-tilt.js/

Have a look at the above website

Kumar-laxmi commented 2 years ago

The cards could be made dynamic in the ways shown in the website

varunKT001 commented 2 years ago

@Kumar-laxmi No doubt that the cards look stunning, but don't you think it would an overkill if we use those effects for simple cards that we have?

If you want to implement that, you can go ahead. But I can't guarantee that your change will get merged. To get merged, it should look good on TomperWear. If they didn't look good or didn't blend well with the overall website, I won't merge that.

So, do you want to work on it?

Kumar-laxmi commented 2 years ago

Look I won't give a tilt effect but a little of zooming effect when we hover our mouse over it.

Kumar-laxmi commented 2 years ago

Look initally it make look weird but if we slowly apply to all in other way around, it will look good

Kumar-laxmi commented 2 years ago

More over the website itself is based on ecommerce and as far as I know, ecommerce website mostly have these stunning effects to draw our attention on

Kumar-laxmi commented 2 years ago

I can only work if you want or else I can close this issue

varunKT001 commented 2 years ago

Okay, you can go ahead with that 🚀 But to get your change get merged, it should look good 👍

Kumar-laxmi commented 2 years ago

yeah obviously

Kumar-laxmi commented 2 years ago

thanks

varunKT001 commented 2 years ago

You can start working on this 👍

varunKT001 commented 2 years ago

@Kumar-laxmi I don't think you are still working on it, It's 24 days 🙂

Kumar-laxmi commented 2 years ago

Oh My God I totally missed it, I will do by today night.

Really sorry for that

varunKT001 commented 2 years ago

@Kumar-laxmi Okay 👍