Show/hide password feature added

varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀

https://tomper-wear.netlify.app

MIT License

38 stars 48 forks source link

Show/hide password feature added #38

Closed Siddhesh777 closed 2 years ago

Siddhesh777 commented 2 years ago

Issue reference: Issue #10

Proposed changes: Added a button which toggles for showing/hiding password

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (please specify)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

Additional info (if any): issue1

issue2

netlify[bot] commented 2 years ago

‼️ Deploy request for tomper-wear rejected. Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: b9271547c06049f867e855730f896ef9a33de599

Siddhesh777 commented 2 years ago

Hey @varunKT001 I think I have all those changes you had suggested before. I created a new pull req just to handle that conflict. sorry for inconvenience :(

varunKT001 commented 2 years ago

@Siddhesh777 More changes needed:

Give the border-radius for the password fields (same as given in the email fields)
You have removed the loading button implementation. You removed the import ../../Button and also changed the <Button> component to normal <button> in the Login and Register pages. Don't make changes to any code that you are not working on. You can look at the current code and make the changes.

PS: It may take some time for me to review any issues/pr because of my exams going on 😅 But still, if you have any doubts, you can ping me on discord 👍

Siddhesh777 commented 2 years ago

hey @varunKT001 😅 Gave the radius for the password fields and also corrected the Button. All the best for your exams!! have a blast😅

varunKT001 commented 2 years ago

@Siddhesh777 I'm sorry for the delay 😅 I have tested it, works fine, and also the UI looks very good. Nice work 👍

Thanks for your contribution 🎉

Siddhesh777 commented 2 years ago

Hey @varunKT001 😅 I think you forgot to add gssoc label

varunKT001 commented 2 years ago

@Siddhesh777 Thanks for reminding me 😅 Added 👍

Siddhesh777 commented 2 years ago

@varunKT001 Can I know why the labels have been removed?

varunKT001 commented 2 years ago

@Siddhesh777 There were multiple Pull Requests on the same topic Toggle Password/ Show-Hide password. That's why I was told to remove the labels for the Pull Requests 😞

Siddhesh777 commented 2 years ago

@varunKT001 It was completely implemented by me. Why the plagiarized tag is there?🙂 No matter how many pull request were there if I had been allotted an issue by the mentor and I had worked on it,How can someone ask you to remove the labels?🙂 If there were multiple pull request then I think the issue itself should not have been allotted.🙂

varunKT001 commented 2 years ago

@Siddhesh777 I'll get this figured out, just wait for some time.

varunKT001 commented 2 years ago

@Siddhesh777 I'm sorry for the trouble 😅. I'm adding the labels again 👍

Siddhesh777 commented 2 years ago

No problem @varunKT001 And thank you very much for the help !😅