Bug: Logging in should be required before filling the cart

varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀

https://tomper-wear.netlify.app

MIT License

38 stars 48 forks source link

Bug: Logging in should be required before filling the cart #43

Closed Siddhesh777 closed 2 years ago

Siddhesh777 commented 2 years ago

What happened?

I think before starting feeling the cart, the user must log in. Because it can happen that some user just surfed the website and added items to the cart but didn't purchase/log in. Then when another person will log in, then those previous items will get added to his cart.

How can we reproduce this bug?

We can keep a button of login in /cart if user isn't logged in

Additional context (if any)

I am contributor at gssoc'22 Please assign this task to me

Urgency (Optional)

No response

github-actions[bot] commented 2 years ago

Hey @Siddhesh777 👋, thank you for raising an issue. Please make sure that it is detailed, and also following the provided template.

varunKT001 commented 2 years ago

@Siddhesh777 If you visit some other e-commerce platforms, you can see that they allow you to fill your cart even if you are not logged in. Also, the cart data is stored in LocalStorage and doesn't require any API call to the TomperWear Server, so it won't create any problem even if we allow users to add to the cart without logging in 👍

So I don't think there is an issue with this 😕

Siddhesh777 commented 2 years ago

yeah alright @varunKT001 👍🏻