varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀
https://tomper-wear.netlify.app
MIT License
38 stars 48 forks source link

toggling password visibility #51

Closed Siddhesh777 closed 2 years ago

Siddhesh777 commented 2 years ago

Issue reference:

50

Proposed changes: changes in /pages/ProfilePage Added the functionality which toggles the visibility of passwords when we user is changing the password in /profile

Type of change:

Please delete options that are not relevant.

Checklist:

Additional info (if any): 1

netlify[bot] commented 2 years ago

👷 Deploy request for tomper-wear pending review. Visit the deploys page to approve it

🔨 Explore the source changes: 6862c10b08aa69b9abeb8931dc87a4328e6d4bde

varunKT001 commented 2 years ago

@Siddhesh777 Before starting to work on any new change, make sure that your forked repository is updated. As I was checking your changes, I saw that the loader was not working and that's because you didn't do the fetch and merge after your previous pull request was merged. The current pull request is fine, just update your forked repository and tag me here 👍

Siddhesh777 commented 2 years ago

hey @varunKT001 I didn't get what should I do actually. Still I had clicked on fetch and merge option of my branch. Is it fine?or should I do something else?

varunKT001 commented 2 years ago

@Siddhesh777 Yes, that's what I meant. Also, before starting to work on any new issue, make sure you do this 👍

Thanks for contributing 🚀

Siddhesh777 commented 2 years ago

@varunKT001 here too you removed the labels..:( What happened?