search

varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀
https://tomper-wear.netlify.app
MIT License
38 stars 48 forks source link

Bug: When nav-bar is opened in small screen, user can still scroll down the homepage hidden behind navbar. #54

Closed Prikshit-anthal closed 2 years ago

Prikshit-anthal commented 2 years ago

What happened?

I opened nav-bar in my mobile, but was able to scroll down homepage directly from opened nav-bar.

How can we reproduce this bug?

Open this project on your mobile. At homepage open nav-bar, then try scrolling. Close nav-bar you will notice homepage has scrolled down.

Screenshot from 2022-03-30 15-05-47

In this screenshot you can see scrollbar at right of navbar being scrolled down.

Additional context (if any)

No response

Urgency (Optional)

Medium priority

github-actions[bot] commented 2 years ago

Hey @Prikshit-anthal 👋, thank you for raising an issue. Please make sure that it is detailed, and also following the provided template.

Prikshit-anthal commented 2 years ago

I'm GSSOC'22 participant. Kindly,assign this issue to me.

varunKT001 commented 2 years ago

Hi @Prikshit-anthal

Yeah, that's a bug, which I didn't notice at first 😅

You already have issue #53 assigned to you. I'm assigning you this one also, but make a separate pull requests for both the issues 👍

Prikshit-anthal commented 2 years ago

@varunKT001 I just wanted to know if you are storing user cart data on backend or not? Because mine is not storing.

varunKT001 commented 2 years ago

@Prikshit-anthal Cart data is stored in the LocalStorage in your browser. After you logout, the cart is cleared 😅 I had plans to store it on the database, but the backend repository didn't see any active contributions so I dropped the plan 😕

Prikshit-anthal commented 2 years ago

Are you ok with firebase as backend, as you have used firebase Auth too. I am well versed in firebase i can contribute in it.

varunKT001 commented 2 years ago

@Prikshit-anthal NO Keep that as it is. Firebase is just for the auth purpose so that we don't have to do all that on the backend. This is a styling related issue, so no point of discussing firebase here 😅 If you want to contribute to the Backend, you can go to the backend repository of TomperWear 👍