Closed varunKT001 closed 2 years ago
Hey @varunKT001 👋, thank you for raising an issue. Please make sure that it is detailed, and also following the provided template.
@varunKT001 Hey,I have checked your isssue.So can you assign it to me
Can I work this issue under GsSoc 22
Hey Can you assign me this issue under GSSOC22
Guys note that the issues will be given on a first come first serve basis.
@Abhinav0909 is the first to claim the issue, so I'm gonna assign it to him 🚀
@sagnik2001 and @sulogna2001, I'll be creating more issues so stay tuned 🎉 Till then, you can also create some issues if you find something you can improve in TomperWear 😄
I'll also be creating a GitHub workflow to automatically assign the issues so you guys don't have to wait for assignment 👍
@Abhinav0909 Make sure you read the contribution guidelines before contributing. Also, while making a pull request, make sure to strictly follow the provided pull request template 👍
@Abhinav0909 Any updates on this? I don't think this should take much time. Try to complete it soon, or I'll need to re-assign it to someone else 😕
Hey @varunKT001 , if this issue is open or will get open can you re-assign it to me
Hey @varunKT001 , if this issue is open or will get open can you re-assign it to me
@sagnik2001 sure 👍
ok ,I will complete this issue by tommorow
@Abhinav0909 Great 👍
hey sorry for the delay can i deliver the issue by tommorow evening.I am working on it.There is a network issue here.Again sorry for delay
Right now I can't do npm start.The answer to that problem statement is to delete node modules which is given to me.
hey sorry for the delay can i deliver the issue by tommorow evening.I am working on it.There is a network issue here.Again sorry for delay
Sure, take your time 👍
Right now I can't do npm start.The answer to that problem statement is to delete node modules which is given to me.
Okay, try that. If still there is problem, you can ping me on TomperWear discord channel, I'll look into that 👍
could you provide me with discord server link so that I can talk to you
You are a participant of GSSoC'22 right? 🙂
yes
Then you should have got the discord invitation link in your selection mail.
ok,
I have joined discord but is there any specific voice channels made for you or where can I have talk with you.It is a little bit confusing since it's first time experience.I couldn't figure out .
You can go to the self-rules channel, and on scrolling down, you'll find TomperWear role. React on it to unlock the TomperWear channel.
It's already 5 days @Abhinav0909 🙁 What's the status?
Yeah but npm start is not happening because of comparability issues of react scripts
Yeah but npm start is not happening because of comparability issues of react scripts
It's working fine for me and all other contributors 🙁 I think that's an issue from your side. I assume that you won't be able to complete this soon, so I'm reassigning the issue 👍
@sagnik2001 You want to work on this?
Hmm ok
hey @varunKT001 you can assign this issue to me
Okay, assigned to you @sagnik2001 🚀
Should I implement this feature only for login button or every button makes a request to the api
Should I implement this feature only for login button or every button makes a request to the API
All the buttons. You can look at the suggestion I gave in the issue.
Hey @varunKT001, while implementing a loading spinner what I found is that you used the same state loader for every field which on changing makes a loader in every button so should I make a separate loading state, or is this ok??
@sagnik2001 It's fine, you can leave it like that 👍
Is your feature request related to a problem? Please describe. Currently while loading, the then is disabled and its opacity is reduced: Change it to something like this when loading:
Describe the solution you thought You may opt for any solution you are comfortable with. Just make sure that whatever you implement is maintainable and does not break any existing functionality. My suggestion would be to create a global button component accepting all the required props and make a check inside the button if the loading state is true.
Additional context (if any)
src/components/StripeCheckout
component for this issue.