varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀
https://tomper-wear.netlify.app
MIT License
38 stars 48 forks source link

Feature Request: Loading spinner when button is disabled #6

Closed varunKT001 closed 2 years ago

varunKT001 commented 2 years ago

Is your feature request related to a problem? Please describe. Currently while loading, the then is disabled and its opacity is reduced: image Change it to something like this when loading: image

Describe the solution you thought You may opt for any solution you are comfortable with. Just make sure that whatever you implement is maintainable and does not break any existing functionality. My suggestion would be to create a global button component accepting all the required props and make a check inside the button if the loading state is true.

Additional context (if any)

github-actions[bot] commented 2 years ago

Hey @varunKT001 👋, thank you for raising an issue. Please make sure that it is detailed, and also following the provided template.

Abhinav0909 commented 2 years ago

@varunKT001 Hey,I have checked your isssue.So can you assign it to me

sagnik2001 commented 2 years ago

Can I work this issue under GsSoc 22

sulogna2001 commented 2 years ago

Hey Can you assign me this issue under GSSOC22

varunKT001 commented 2 years ago

Guys note that the issues will be given on a first come first serve basis.

@Abhinav0909 is the first to claim the issue, so I'm gonna assign it to him 🚀

@sagnik2001 and @sulogna2001, I'll be creating more issues so stay tuned 🎉 Till then, you can also create some issues if you find something you can improve in TomperWear 😄

I'll also be creating a GitHub workflow to automatically assign the issues so you guys don't have to wait for assignment 👍

varunKT001 commented 2 years ago

@Abhinav0909 Make sure you read the contribution guidelines before contributing. Also, while making a pull request, make sure to strictly follow the provided pull request template 👍

varunKT001 commented 2 years ago

@Abhinav0909 Any updates on this? I don't think this should take much time. Try to complete it soon, or I'll need to re-assign it to someone else 😕

sagnik2001 commented 2 years ago

Hey @varunKT001 , if this issue is open or will get open can you re-assign it to me

varunKT001 commented 2 years ago

Hey @varunKT001 , if this issue is open or will get open can you re-assign it to me

@sagnik2001 sure 👍

Abhinav0909 commented 2 years ago

ok ,I will complete this issue by tommorow

varunKT001 commented 2 years ago

@Abhinav0909 Great 👍

Abhinav0909 commented 2 years ago

hey sorry for the delay can i deliver the issue by tommorow evening.I am working on it.There is a network issue here.Again sorry for delay

Abhinav0909 commented 2 years ago

Right now I can't do npm start.The answer to that problem statement is to delete node modules which is given to me.

varunKT001 commented 2 years ago

hey sorry for the delay can i deliver the issue by tommorow evening.I am working on it.There is a network issue here.Again sorry for delay

Sure, take your time 👍

varunKT001 commented 2 years ago

Right now I can't do npm start.The answer to that problem statement is to delete node modules which is given to me.

Okay, try that. If still there is problem, you can ping me on TomperWear discord channel, I'll look into that 👍

Abhinav0909 commented 2 years ago

could you provide me with discord server link so that I can talk to you

varunKT001 commented 2 years ago

You are a participant of GSSoC'22 right? 🙂

Abhinav0909 commented 2 years ago

yes

varunKT001 commented 2 years ago

Then you should have got the discord invitation link in your selection mail.

Abhinav0909 commented 2 years ago

ok,

Abhinav0909 commented 2 years ago

I have joined discord but is there any specific voice channels made for you or where can I have talk with you.It is a little bit confusing since it's first time experience.I couldn't figure out .

varunKT001 commented 2 years ago

You can go to the self-rules channel, and on scrolling down, you'll find TomperWear role. React on it to unlock the TomperWear channel.

varunKT001 commented 2 years ago

It's already 5 days @Abhinav0909 🙁 What's the status?

Abhinav0909 commented 2 years ago

Yeah but npm start is not happening because of comparability issues of react scripts

Abhinav0909 commented 2 years ago

Yeah but npm start is not happening because of comparability issues of react scripts

varunKT001 commented 2 years ago

It's working fine for me and all other contributors 🙁 I think that's an issue from your side. I assume that you won't be able to complete this soon, so I'm reassigning the issue 👍

@sagnik2001 You want to work on this?

Abhinav0909 commented 2 years ago

Hmm ok

sagnik2001 commented 2 years ago

hey @varunKT001 you can assign this issue to me

varunKT001 commented 2 years ago

Okay, assigned to you @sagnik2001 🚀

sagnik2001 commented 2 years ago

Should I implement this feature only for login button or every button makes a request to the api

varunKT001 commented 2 years ago

Should I implement this feature only for login button or every button makes a request to the API

All the buttons. You can look at the suggestion I gave in the issue.

sagnik2001 commented 2 years ago

Hey @varunKT001, while implementing a loading spinner what I found is that you used the same state loader for every field which on changing makes a loader in every button so should I make a separate loading state, or is this ok?? Screenshot from 2022-03-06 20-19-41

varunKT001 commented 2 years ago

@sagnik2001 It's fine, you can leave it like that 👍