search

varunKT001 / tomper-wear-ecommerce

E-commerce web-application for selling clothing essentials 😀
https://tomper-wear.netlify.app
MIT License
38 stars 48 forks source link

Issue 39 Fixed #66

Closed mani200307 closed 1 year ago

mani200307 commented 1 year ago

Issue reference: In reference to issue https://github.com/varunKT001/tomper-wear-ecommerce/issues/39

Proposed changes: Enhancement : Navigation button to move to the top of the page

Type of change: Added navigation button to move to the top of the page

Checklist: My code follows the style guidelines of this project I have performed a self-review of my own code I have commented my code, particularly in hard-to-understand areas I have made corresponding changes to the documentation My changes generate no new warnings Additional info (if any):

netlify[bot] commented 1 year ago

Deploy request for tomper-wear pending review.

Visit the deploys page to approve it

Name Link
Latest commit b409aa675b5e8c9bec2589f2a5d07aec062107b9
varunKT001 commented 1 year ago

@mani200307 The look of the button doesn't match the website's theme. You might want to use an arrow icon, along with some reduced border-radius and primary brown color (you can find the list of colors in the global CSS file). Also, the button doesn't fit well on small-screen devices, so please look into that also.

mani200307 commented 1 year ago

Sure I'll modify.

mani200307 commented 1 year ago

image

@varunKT001, Is this style fine for the scroll to top button? Any changes required?

varunKT001 commented 1 year ago

@mani200307 Keep it square with some border-radius. Also, give some padding to the arrow doesn't look congested inside the shape.

mani200307 commented 1 year ago

Thanks @varunKT001, Now, I made the changes and did commit. Now, that button is responsive too.

varunKT001 commented 1 year ago

@mani200307 I've left some reviews, please look into those.