search

varunbln / Spawners

Pocketmine plugin made in PHP implementing stackable spawners
GNU Lesser General Public License v3.0
35 stars 23 forks source link

Exclude all Entities that are not in the ArrayList. #97

Closed HighTecDev closed 3 years ago

HighTecDev commented 3 years ago

This prevents stacked onjectEntities like ArmorStands, Lore, etc. (what causes a Duplicating of the Content)

iZeaoGamer commented 3 years ago

I've tested this commit, and though the commit is pretty good, it causes crashes with Item Entities, since they don't have getName() function, so adding a instanceof living check will solve the issue. As I've tested it using my custom edits of it, and it doesn't crash, when I added the instanceof living check. Everything else is spot on. The crash was an undefined function getName(). I'm not going to check the logs for it, as it's obvious where it is. But an $entity instanceof Living check will for sure fix that, as tested.

HighTecDev commented 3 years ago

I dont think that the RepoOwner is really active so i will delete this PR soon. If you want you can overtake it @iZeaoGamer

iZeaoGamer commented 3 years ago

Overtake what?

varunbln commented 3 years ago

sorry, was quite busy the past few days, if you can fix thee getName() issue I'll get it merged

iZeaoGamer commented 3 years ago

Do you want me to take over the merge? Like maybe add the changes, fix them, and then make a new PR?

iZeaoGamer commented 3 years ago

I made the merge {#102)

varunbln commented 3 years ago

Thank you!