search

varvet / godmin

Admin framework for Rails 5+
http://godmin-sandbox.herokuapp.com
MIT License
486 stars 47 forks source link

Add captions to tables #187

Closed ramhoj closed 7 years ago

ramhoj commented 8 years ago

semantic and nice when testing

jensljungblad commented 8 years ago

Does it still work in tests if we would add a .sr-only class to the caption? That is, only include it for screen readers. Visually we already have the information about what table we're listing (e.g. articles) in the breadcrumb.

ramhoj commented 7 years ago

Pretty sure the caption can have any css class attached to it without casing any problems for the Rspec matcher.