search

varvet / pundit

Minimal authorization through OO design and pure Ruby classes
MIT License
8.29k stars 632 forks source link

Rubocop Housekeeping #605

Closed dgmstuart closed 5 years ago

dgmstuart commented 5 years ago

The intention of this PR is to clean up the Rubocop config, and make it forwards-compatible as much as possible without dropping support for ruby 2.1 and 2.2.

There are a lot of things in the rubocop config which don't really need to be there: a number seem to have been copied from some other project.

Where there are no issues, or the issues can be easily fixed to be in line with the rubocop defaults, then it feels like a good idea to remove these exceptions, at least in part because it insulates us from future changes to the cop name or options.

dgmstuart commented 5 years ago

@rubyrider @guilhermecortes @olleolleolle you've all been involved in the rubocop discussion - feel free to comment if you have a moment - otherwise I'll merge this later this week.

rubyrider commented 5 years ago

Looks good!