Policy spec template fix for RSpec/LeadingSubject

varvet / pundit

Minimal authorization through OO design and pure Ruby classes

MIT License

8.28k stars 630 forks source link

Policy spec template fix for RSpec/LeadingSubject #682

Closed stgeneral closed 3 years ago

stgeneral commented 3 years ago

Policy spec template fix for RSpec/LeadingSubject - https://www.rubydoc.info/gems/rubocop-rspec/1.7.0/RuboCop/Cop/RSpec/LeadingSubject.

Burgestrand commented 3 years ago

Hi! Thanks for the PR, but I won't merge it.

The reason for not merging this is the same to what I mentioned in your other PR: https://github.com/varvet/pundit/pull/683#issuecomment-902513187

In short I won't merge style changes that aren't enforced. Rubocop passes on master and because of that I can't see a logical reason to why it would make sense to merge this.

stgeneral commented 3 years ago

Thank you for the detailed clarifications!

I guess that Rubocop passes on master because RSpec/LeadingSubject is a part of rubocop-rspec, which seems not included in pundit.gemspec. I'll try to verify and confirm if that's the case.