search

varvet / pundit

Minimal authorization through OO design and pure Ruby classes
MIT License
8.24k stars 627 forks source link

updating rubocop config file #702

Closed MarceloAGuimaraes closed 2 years ago

MarceloAGuimaraes commented 2 years ago

https://github.com/varvet/pundit/issues/701

Burgestrand commented 2 years ago

Hi! Thanks for doing this work, but your PR is adding warnings to our rubocop CI, not removing them.

I'm trying to aggressively clean up this repo so I'll close this PR. That doesn't mean the discussion ends, but with the current rubocop version/config there are no rubocop.yml warnings in main.

We might need to upgrade rubocop in pundit to a more recent version to get the warnings you're seeing. You're more than welcome to reopen this PR if that's something you'd be interested in doing, and subsequently that would probably allow you to change these config names without adding warnings to the rubocop run on CI.

MarceloAGuimaraes commented 2 years ago

@Burgestrand , maybe we can think to upgrade the rubocop to a new version. They already released the 1.24, but the minimum ruby to this version is the 2.5.0. Do we have a problem with this requirement ?

Burgestrand commented 2 years ago

@Burgestrand , maybe we can think to upgrade the rubocop to a new version. They already released the 1.24, but the minimum ruby to this version is the 2.5.0. Do we have a problem with this requirement ?

That should be OK, the oldest version of Ruby that we support is typically the oldest non-EOL Ruby from https://www.ruby-lang.org/en/downloads/ — today that's 2.6. Anything older we can ignore.

MarceloAGuimaraes commented 2 years ago

Awesome. I just created the pr https://github.com/varvet/pundit/pull/708.