Refactors the pundit_model function to return the correct class name when receiving a module as a record - Githubissues

varvet / pundit

Minimal authorization through OO design and pure Ruby classes

MIT License

8.21k stars 624 forks source link

Refactors the pundit_model function to return the correct class name when receiving a module as a record #770

Closed TheDevJoao closed 11 months ago

TheDevJoao commented 1 year ago

This PR resolves issue #744

What did I do?

Refactored the pundit_model function to return the correct class name when receiving a module as a parameter.
Added unit tests to the pundit_spec.rb file as it was missing tests for the pundit_model function.

To-do

[X] I have read the contributing guidelines.
[X] I have added relevant tests.
[X] No documentation alterations required
[X] I have made sure the individual commits are meaningful.
[X] I have added relevant lines to the CHANGELOG.

Burgestrand commented 11 months ago

Thank you for the PR.

I don't understand why we would want to go from a module instance, to a string, and then back to the original module.

I'm not sure the issue this refers to really is an issue, see my comment: https://github.com/varvet/pundit/issues/744#issuecomment-1638106159

Closing for now, waiting to see how #744 unfolds.