search

varyform / atom-facepalm

OMG... this code 0_0
MIT License
4 stars 1 forks source link

Contextual Facepalming #1

Closed smashwilson closed 10 years ago

smashwilson commented 10 years ago

I laughed for a good ten minutes when I saw this get published... and then I decided that I just had to link it up to @tombell's excellent test-status package. So, here's a pull request that accomplishes just that. While your tests are failing, Atom expresses its displeasure!

contextual-facepalm

Actually, it's a little more flexible than that; it lets you specify any set of events that will trigger the facepalm, and any set that will turn it off again. If the activation events are empty (as is the default), every editor will be facepalming as they do now. If you specify deactivation events but no activation events, all editors will start facepalming but turn off when a deactivation event happens.

I did need to change the package name in package.json while I did this, which will probably break apm publish. :unamused: Sorry about that, but if I didn't, npm broke and I couldn't add emissary as a dependency for the event management stuff.

varyform commented 10 years ago

Hi @smashwilson, Sorry for late reply, looks like I missed PR notification. Just checked your changes – looks great :) Could you please update the readme? Will re-publish with a new name once it's done. Thanks!

smashwilson commented 10 years ago

Hey @varyform! No worries, clearly this is both of our top priorities :wink: I added a section to the README on configuration as requested.