search

vasani-arpit / WBOT

A simple Web based BOT for WhatsApp™ in NodeJS 😜. Working as of 📅 Feb 4th, 2024
Other
987 stars 314 forks source link

docs: Improved the docs. #267

Closed nikhilmaske-2001 closed 2 years ago

nikhilmaske-2001 commented 2 years ago

This PR contains fix for some typos.

vasani-arpit commented 2 years ago

Congrats on your first contribution !!

Please run npm version minor and push the changes in the same branch. GH workflow will not accept code change without version update.

nikhilmaske-2001 commented 2 years ago

@vasani-arpit I have changed the version by the command, Can you review it again?

vasani-arpit commented 2 years ago

command npm version minor will add a new commit in your git history. You need to push those commits into this(nikhilmaske-2001:docs) branch.

nikhilmaske-2001 commented 2 years ago

I think it doesn't make sense to make a seperate commit for every version change. It unnecessarly stack into the project commits. We can either make something that will allow GH workflow to allow no version change or just add that version change in the one commit only(which contain any change). What's your point of view on it?

vasani-arpit commented 2 years ago

We don't have/use the dev branch. so every feature is being directly merged in prod as an individual release. If we would have a dev branch then we would merge all the features in that branch and update the version in there before merging it to prod/main/master one. Sometimes this thing helps me by failing, I have to manually pull the code in my local for version update and by doing so I mostly test everything. that way I can be sure that everything works fine.

nikhilmaske-2001 commented 2 years ago

Yeah, makes sense. I will update the PR soon.

nikhilmaske-2001 commented 2 years ago

@tbs-arpit Pushed the changes, can you review it again?