search

vasanthk / react-bits

✨ React patterns, techniques, tips and tricks ✨
https://vasanthk.gitbooks.io/react-bits
Creative Commons Attribution 4.0 International
16.97k stars 1.1k forks source link

Is it OK to fork it and translate into other language by myself? #85

Closed hateonion closed 7 years ago

vasanthk commented 7 years ago

You are most welcome to. Please do send in a PR to the main repo readme once done. I shall link it :)

hateonion commented 7 years ago

Hi, @vasanthk Still trying to figure it out what's the best way to share my translation. I've translated Conditional in JSX and Async Nature Of setState()
https://github.com/hateonion/react-bits and pushed to my forked repo. But seems I will override the original stuff. Am thinking 2 approaches,

  1. Still work on my forked repo, but create a CN-Zh folder and restructure it in that folder, then send pr to the master repo.
  2. I will create another repo and push my translation in that repo. Once I finish it, I will send a pr to update the Readme and attach my repo link.

Which one would you prefer?

vasanthk commented 7 years ago

@hateonion Number 2 sounds fine. In the past, for js-bits a contributor did it that way. Might be easier for you to create your own gitbook as well similar to https://vasanthk.gitbooks.io/react-bits

hateonion commented 7 years ago

Cool Thanks Man