search

vasconsaurus / produce_in_season

0 stars 0 forks source link

Feature/main page frontend #44

Closed vasconsaurus closed 2 years ago

vasconsaurus commented 2 years ago

I finished the first version for the main page's frontend.

Since the asset pipeline is giving us some trouble, I uploaded the images we are using to oneDrive, and linked from there. This way we can at least validate if the way the css is ok, and move on to the other pages, while we work on the asset pipeline.

@tcione tell me if you think the way I organized things is ok/makes sense, if we can continue like this. As always, I'm open to suggestions :]

vasconsaurus commented 2 years ago

Nice to see things taking shape. I did a quick review (will do a more detailed one over the weekend), but I think there are already some topics for you to consider.

When it comes to PR description, would you mind putting some screen captures of the outcome? It'd make it easier for me to evaluate without running the code :D

No problem! I'm sorry, it completely slipped my mind. I made two videos, one with a bigger width, and one on mobile. Let me know if something like this helps.

https://user-images.githubusercontent.com/87862340/187267822-6ddbab84-bfb9-41f5-9102-24433609da32.mov

https://user-images.githubusercontent.com/87862340/187267950-65fbdee8-3aaf-4745-8058-c933300b4452.mov

vasconsaurus commented 2 years ago

@tcione , I think now everything is done?

Alt Text

tcione commented 2 years ago

@vasconsaurus yeap, pretty much :)