search

vasconsaurus / produce_in_season

0 stars 0 forks source link

Add layout to produce items/index #52

Closed vasconsaurus closed 1 year ago

vasconsaurus commented 2 years ago

Closes #47

The first version of our produce items index front-end.

On desktop Screen Shot 2022-10-17 at 14 19 05

On mobile Screen Shot 2022-10-17 at 14 19 22

Short video https://user-images.githubusercontent.com/87862340/196242632-0ebe5dde-6786-4470-ae9f-bb8246230481.mov

vasconsaurus commented 2 years ago

@tcione I was checking Figma and realized we had changed this page to show the months on the produce item card:

Screen Shot 2022-10-17 at 14 28 00

I'll update this PR to include this change, so there is no need to review it now. 😬

vasconsaurus commented 2 years ago

@tcione I think we are done with this one, could you review it? 🙂

vasconsaurus commented 1 year ago

@tcione There is a NoMethodError failure in one of our tests, but locally everything seems to be fine, those tests are passing. I tried making a couple of changes and pushing it to the repo, but I wasn't lucky 😅 Is there a better way I could debug these tests that don't fail locally?

Screenshot 2022-11-09 at 15 14 14

Screenshot 2022-11-09 at 15 16 55
tcione commented 1 year ago

@vasconsaurus The NoMethodError issue seems solved. Or did I miss something?

vasconsaurus commented 1 year ago

@vasconsaurus The NoMethodError issue seems solved. Or did I miss something?

Yes! There were two problems, that and the database cleaner config. I'm not sure they were related though.

Anyway, I couldn't make your suggested change for the test work, so I went back to how it was.