vasia / gelly-streaming

An experimental Graph Streaming API for Apache Flink
Apache License 2.0
140 stars 44 forks source link

Adding libraries for connected components and bipartiteness #15

Closed Zainab-Abbas closed 8 years ago

Zainab-Abbas commented 8 years ago

Pull request for library package and tests of connected components and bipatiteness check

vasia commented 8 years ago

Thanks for the PR @Zainab-Abbas! I've left some comments for improvements. Let us know if you need help.

Zainab-Abbas commented 8 years ago

Thank you @vasia for the comments i will fix them soon, i will ask incase i got stuck

senorcarbone commented 8 years ago

:+1: @Zainab-Abbas good job! Please cleanup the original examples as well. As far as I can see there is yet another ConnectedComponents.java under examples which is unchanged. You can rename that into ConnectedComponentsExample or something and refactor it to use the actual library :)

Zainab-Abbas commented 8 years ago

@senorcarbone thanks :+1: will do that soon :)

Zainab-Abbas commented 8 years ago
vasia commented 8 years ago

Thanks for updating the PR @Zainab-Abbas! I left a few comments. Let me know if you need help.

Zainab-Abbas commented 8 years ago

Thank you for the comments @vasia I have replied to you comments with the changes i made :) let me know if i am wrong some where

vasia commented 8 years ago

Hey @Zainab-Abbas, I see your comments but I don't see your changes... Did you forget to push your commit? :)

Zainab-Abbas commented 8 years ago

@vasia just pushed my commit now :)

Zainab-Abbas commented 8 years ago

@vasia Made some changes in the javadocs to explain more about the functions :) let me know if it is correct

vasia commented 8 years ago

Thank you @Zainab-Abbas. I will merge this :)

Zainab-Abbas commented 8 years ago

@vasia good 👍 you are welcome :)