Closed Zainab-Abbas closed 8 years ago
Thanks for the PR @Zainab-Abbas! I've left some comments for improvements. Let us know if you need help.
Thank you @vasia for the comments i will fix them soon, i will ask incase i got stuck
:+1: @Zainab-Abbas good job! Please cleanup the original examples as well. As far as I can see there is yet another ConnectedComponents.java under examples which is unchanged. You can rename that into ConnectedComponentsExample
or something and refactor it to use the actual library :)
@senorcarbone thanks :+1: will do that soon :)
Thanks for updating the PR @Zainab-Abbas! I left a few comments. Let me know if you need help.
Thank you for the comments @vasia I have replied to you comments with the changes i made :) let me know if i am wrong some where
Hey @Zainab-Abbas, I see your comments but I don't see your changes... Did you forget to push your commit? :)
@vasia just pushed my commit now :)
@vasia Made some changes in the javadocs to explain more about the functions :) let me know if it is correct
Thank you @Zainab-Abbas. I will merge this :)
@vasia good 👍 you are welcome :)
Pull request for library package and tests of connected components and bipatiteness check